Make propagators conform to spec #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* do not modify / set an invalid span in the passed context in case a propagator did not manage to extract * in case no context is passed to propagator.extract assume the root context as default so that a new trace is started instead of continung the current active trace in case extraction fails * fix also ot-trace propagator which compared int with str trace/span ids when checking for validity in extract
mariojonke
requested review from
a team,
codeboten and
hectorhdzg
and removed request for
a team
srikanthccv
reviewed
May 6, 2021
ocelotl
reviewed
May 26, 2021
| @@ -42,6 +42,9 @@ def extract( | |||
| context: typing.Optional[Context] = None, | |||
| getter: Getter = default_getter, | |||
| ) -> Context: | |||
| if context is None: | |||
| context = Context() | |||
There was a problem hiding this comment.
In this PR description you mention this, @mariojonke:
Propagators should return the passed in context (or the current one if none was given) if nothing could be extracted.
Should we use the current context instead of instantiating a new one?
There was a problem hiding this comment.
We decided in the SIG meeting to use the root context as default because the current context would continue a possible active trace instead of starting a new one if extracting from the carrier fails (see also open-telemetry/opentelemetry-python#1765 (comment))
See also PR in the core repo: open-telemetry/opentelemetry-python#1811
ocelotl
approved these changes
May 26, 2021
srikanthccv
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Propagators use the root context as default value for the extract operation. Additionally avoid modifying the context in case there is nothing to extract or the carrier does not hold valid data.
Fixes open-telemetry/opentelemetry-python#1765
Fixes also an issue in the
ot-tracepropagator where trace/span id validity was comparing str with int values.Type of change
How Has This Been Tested?
unit tests have been added/adapted
Does This PR Require a Core Repo Change?
Checklist: